Serial-ATA / Serial-ATA/lofty-rs
Expose tag parsing internals
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 359
- Forks
- 77
- Avg merge
- 12h 54m
- Merged PRs (30d)
- 11
Description
It may not always be convenient to read an entire file. At this point, the tag parsing internals change infrequently enough that it'd probably be safe to expose them.
It'd be nice to make all of the parse functions have a similar signature to parse_id3v2:
https://github.com/Serial-ATA/lofty-rs/blob/6e555d1cb668737c629d0e76b12883532e8bdbce/src/id3/v2/read.rs#L10-L17
Some still have unnecessary Seek bounds or are just too clunky to use externally in their current state (like VorbisComments).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/id3/v2/read.rs and the parse_id3v2 signature linked in the issue, then inspect the other tag parsing functions and VorbisComments. The work is complete when the parsing functions have consistent externally usable signatures without unnecessary Seek bounds or clunky interfaces.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100