Web UI sends `shutdown` on tab close instead of `restart`

Open Beginner friendly
#256 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
python
Domain
frontend

Research direction

Start at destroyPlayer() in the serve-mode web UI and inspect how client/goodbye.reason is assigned on tab close versus the explicit user-stop button. Change the unexplained graceful-disconnect default to restart while preserving user_request for explicit stops, then verify both goodbye reasons are sent as intended.

Written by the indexing model from the issue text.

Description

Severity: 🟠 high

destroyPlayer() in the serve-mode web UI defaults to client/goodbye.reason = 'shutdown'; only the explicit user-stop button sends user_request. A user who simply closes the browser tab is therefore reported to the server as having "shut down permanently", which (per the spec) suppresses server-side auto-reconnect. The spec implies the default for an unexplained graceful disconnect should be restart.


Source: docs/goodbye-and-operational-state.md §divergence
Full audit branch: claude/stream-sync-correction-sdks-AWoNC
Per-SDK digest: sdk-issues digest

Filed from a cross-SDK conformance audit; see digest for the full per-SDK punch list.

Dominant language
Python
Stars
190
Forks
36
Avg merge
11d 19h
Merged PRs (30d)
2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Sendspin/sendspin-python-cli

All issues in Sendspin/sendspin-python-cli

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.