SemanticMediaWiki / SemanticMediaWiki/SemanticFormsSelect
Fix deprecation notice required after optional parameters
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 6
- Forks
- 14
- PR merge metrics
- No merged PRs in 30d
Description
Issue
This (minor) issue is about https://github.com/SemanticMediaWiki/SemanticFormsSelect/blob/master/src/SemanticFormsSelectInput.php#L72
In PHP 8 adding required after optional parameters in a function/method has become deprecated (1). I don't know what's preferable as a solution: reshuffle the sequence or convert the required parameters to optional ones by adding defaults. I'll leave that up to your good judgment.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/SemanticFormsSelectInput.php around line 72 and inspect the function or method signature that places required parameters after optional ones. Compare the two alternatives described in the issue, then verify the chosen signature under PHP 8. Done means the deprecation notice is no longer emitted without changing the intended call behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100