SeleniumHQ / SeleniumHQ/selenium

[java] DriverFinderTest property fixture doesn't clear/restore selenium.webdriver.verbose

Open Beginner friendly
#17,836 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
34.5k
Forks
8.7k
Avg merge
2d 1h
Merged PRs (30d)
92

Description

### Motivation

Follow-up to #17832/#17833. That PR's round-2 review pass fixed the identical fixture-hygiene gap (test setup only saving/clearing `selenium.debug`, not its legacy alias `selenium.webdriver.verbose`) in `LoggingOptionsTest.java`, `RemoteWebDriverInitializationTest.java`, and `RetryRequestTest.java`.

`java/test/org/openqa/selenium/remote/service/DriverFinderTest.java:81-100` has the same gap: its property save/restore only handles `selenium.debug`, so a JVM with `selenium.webdriver.verbose` set externally could leak state across tests in this file. It was out of scope for the round-2 coder (not in the original findings list) so it's tracked here rather than fixed silently.

### Suggested fix

Mirror the fixture pattern already applied to the three files above: save both properties before the test, clear both, restore both after.

### Context
Umbrella tracker: #17833

Contributor guide

Open the contributing guide

Research direction

Open java/test/org/openqa/selenium/remote/service/DriverFinderTest.java:81-100 and compare its fixture with the corresponding setup in LoggingOptionsTest.java, RemoteWebDriverInitializationTest.java, and RetryRequestTest.java. Run DriverFinderTest after updating the fixture; done means both selenium.debug and selenium.webdriver.verbose are saved, cleared before the test, and restored afterward.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
testing
Issue type
Bug
Difficulty
1/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
88/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.