Add support more TLS cryptography libs
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 9.9k
- Forks
- 734
- Avg merge
- 6h 36m
- Merged PRs (30d)
- 8
Description
Motivation
Currently, we hardcode sqlx?/tls-rustls on runtime-{}-rustls, but sqlx support many other features:
tls-rustls = ["tls-rustls-ring"] # For backwards compatibility
tls-rustls-aws-lc-rs = []
tls-rustls-ring = ["tls-rustls-ring-webpki"] # For backwards compatibility
tls-rustls-ring-webpki = []
tls-rustls-ring-native-roots = []
I think we should support at least aws-lc-rs, because it is now the standard crypto library.
Proposed Solutions
Add feature like runtime-{}-rustls-ring (default via runtime-{}-rustls) and runtime-{}-rustls-aws-lc-rs
Additional Information
This isn't so much about one library offering advantages over another, but rather the problem that the lack of customization can lead to conflicts across libraries when someone hardcodes a variant.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the runtime-{}-rustls feature definitions and inspect how they currently enable sqlx?/tls-rustls. Add support for the proposed ring and aws-lc-rs variants while preserving the existing default behavior, then verify the feature configuration does not force a conflicting crypto-library choice.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- database
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100