typehint missing for Wait method.

Open
#63 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
testing-qa

Research direction

Locate the Wait.for_() and Wait.for_the() methods and inspect their current annotations and the condition types they accept. Update the annotations to account for conditions that accept WebElement, then run the relevant available checks to confirm the type hints are consistent.

Written by the indexing model from the issue text.

Description

When using Wait.for_() or Wait.for_the() methods, the annotation only says it accepts a Target but this is technically incorrect since the exepcted conditon used could accept WebElement.

The annotations should be updated to reflect this.

Dominant language
Python
Stars
7
Forks
2
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ScreenPyHQ/screenpy_selenium

All issues in ScreenPyHQ/screenpy_selenium

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.