Reorder pre-commit hooks so that `ruff-format` and `ruff-check` happens before `mypy`

Open Beginner friendly
#7,204 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
62/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Quiet
Tech stack
python
Domain
tooling

Research direction

Find the repository's pre-commit configuration and inspect the current order of the ruff-format, ruff-check, and mypy hooks. Run the relevant pre-commit validation, then confirm that both Ruff hooks precede mypy and that the reported mypy line numbers remain correct when formatting changes are required.

Written by the indexing model from the issue text.

Description

If there are formatting changes required by ruff-format or ruff-check, then the reported mypy errors return the wrong line number. Reordering them should keep the line number correct.

Dominant language
Python
Stars
724
Forks
317
Avg merge
3d 20h
Merged PRs (30d)
9

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from SciTools/iris

All issues in SciTools/iris

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.