Peloton workflow possibly struggling with duplicate items

Open
#248 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
tooling

Research direction

Start in peloton/update_project.py around lines 1331-1333 and inspect how the issues_discussions dataframe is built and consumed. Run the Peloton workflow or examine its query results for duplicate issue, pull request, or discussion IDs. Done means the workflow reliably prevents duplicate items from reaching downstream handling, with the behavior checked against a representative duplicate case.

Written by the indexing model from the issue text.

Description

🚴‍♀️ peloton

Have seen a couple of runs this weekend where the Peloton workflow has attempted to add the same item to the project twice in the same query. GitHub handles this but our workflow cannot handle it downstream. I was unable to replicate the problem this morning. If it materialises again we might consider adding something after this line:

https://github.com/SciTools/.github/blob/40368fc68f2840e6c69201c7ef4e32a2afa87f3b/peloton/update_project.py#L1331-L1333

The issues_discussions dataframe uses the ID of the issue/pr/discussion as the index. We can enforce this to be unique (it is certainly expected to be).

Dominant language
Python
Stars
3
Forks
7
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from SciTools/.github

All issues in SciTools/.github

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.