SciSharp / SciSharp/BotSharp

Update the conversation status as closed

Open
#216 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
3.1k
Forks
651
Avg merge
15h 2m
Merged PRs (30d)
36

Description

A Conversation Hook needs to be implemented to update Conversation to the closed state.

The conversation will be closed in two situations:

  • When the conversation ends normally and is triggered by LLM,;
  • When the idle time is exceeded and the conversation is forcibly ended by the background;

No matter which situation is triggered, the OnConversationEnding method in IConversationHook will be called.

Therefore we can implement a new conversation hook here and update the conversation status to ConversationStatus.Closed in the OnConversationEnding function.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the Conversation Hook documentation and inspect the services under src/Infrastructure/BotSharp.Core/Conversations/Services. Trace where IConversationHook.OnConversationEnding is invoked for normal and idle-time endings. Done means a hook updates the conversation to ConversationStatus.Closed in both paths, with relevant tests if the existing conversation service test structure provides them.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
ai, backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.