SciML / SciML/SparseWithDenseRowColMatrices.jl
QA: Aqua/JET findings marked @test_broken pending fix
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 0
- Forks
- 1
- Avg merge
- 14m
- Merged PRs (30d)
- 6
Description
The grouped-tests QA group runs Aqua.test_all on SparseWithDenseRowColMatrices. One Aqua sub-check fails and is marked @test_broken in test/qa/qa.jl so the QA CI group is green; it should be fixed and un-broken.
Finding (Aqua deps_compat, extras sub-check):
-
The package lists
Pkg(UUID44cfe95a-1eb2-52ea-b672-e2afdf69b78f) in[extras]/ thetesttarget ofProject.tomlbut declares no[compat]entry forPkg. Aqua'stest_deps_compat(check_extras = true) therefore fails:SparseWithDenseRowColMatrices does not declare a compat entry for the following extras: Pkg [44cfe95a-1eb2-52ea-b672-e2afdf69b78f]All other Aqua sub-checks pass (unbound type params, undefined exports, project/test compat, stale deps, deps compat for deps & weakdeps, piracy, persistent tasks).
Fix: add Pkg = "1" (or appropriate bound) to [compat] in Project.toml, then remove the deps_compat = false / @test_broken from test/qa/qa.jl and let Aqua.test_all run deps_compat normally.
Note: the QA driver include path in test/runtests.jl was also corrected (it pointed at test/qa.jl instead of test/qa/qa.jl), which is why this finding was previously masked (QA never ran).
Ignore until reviewed by @ChrisRackauckas.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with Project.toml and test/qa/qa.jl, then run the grouped-tests QA path through Aqua.test_all. Confirm the Pkg extra has a compat bound, remove the deps_compat exclusion and @test_broken marker, and verify that the QA group passes normally. The corrected include path in test/runtests.jl explains why this check was previously masked.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 65/100