SciML / SciML/SparseMatrixIdentification.jl

QA: Aqua/JET findings marked @test_broken pending fix

Open
#35 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
4
Forks
1
Avg merge
3h 47m
Merged PRs (30d)
7

Description

While finalizing the grouped-tests CI QA group, Aqua.test_all(SparseMatrixIdentification) surfaces genuine deps_compat findings that need to be fixed. To keep the QA group green so the grouped-tests-ci PR can merge, these specific Aqua sub-checks are run with deps_compat=false and replaced by @test_broken false markers (which auto-flag once fixed). All other Aqua checks (method ambiguity, unbound type params, undefined exports, Project.toml comparison, stale deps, piracy, persistent tasks) and JET.test_package pass.

Findings (Aqua test_deps_compat)
  1. depsSparseMatrixIdentification does not declare a [compat] entry for the following dependencies:
    • LinearAlgebra
    • SparseArrays
  2. extrasSparseMatrixIdentification does not declare a [compat] entry for the following test extra:
    • Pkg
Fix

Add [compat] bounds for these stdlib deps/extras (e.g. LinearAlgebra = "1", SparseArrays = "1", Pkg = "1"), then remove the deps_compat=false kwarg and the @test_broken markers in test/qa/qa.jl so the checks run normally again.

These are currently @test_broken in the grouped-tests QA group so CI is green. Ignore until reviewed by @ChrisRackauckas.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the package Project.toml to inspect dependency and test-extra declarations, then read test/qa/qa.jl for the grouped-tests QA setup and its current Aqua overrides. Run the grouped-tests CI QA group after updating the compatibility metadata and removing the temporary overrides; done means the Aqua dependency-compatibility checks pass normally.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
ci-cd, testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.