SciML / SciML/SciMLIterators.jl

QA: Aqua/JET findings marked @test_broken pending fix

Open
#9 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
1
Forks
1
Avg merge
6h 24m
Merged PRs (30d)
4

Description

The grouped-tests-ci conversion runs the QA group (Aqua + JET) on ubuntu-latest for Julia [lts, 1]. Two genuine Aqua sub-checks currently fail and have been wrapped as @test_broken in test/qa/qa.jl so the QA group is green and the conversion PR can merge. They should be fixed and un-broken:

  1. Aqua piracies — 2 type-piracy methods detected:

    • tuples(integrator::SciMLBase.DEIntegrator) @ src/SciMLIterators.jl:137
    • tuples(sol::SciMLBase.AbstractTimeseriesSolution) @ src/SciMLIterators.jl:138
      Both define methods of tuples (owned by another package / Base) on types owned by SciMLBase. Needs either upstreaming the tuples overloads or a non-pirating API.
  2. Aqua deps_compat (extras) — the main Project.toml declares Aqua and JET in [extras] but has no [compat] entries for them:

    • Aqua [4c88cf16-eb10-579e-8560-4a9242c79595]
    • JET [c3a54625-cd67-489e-a8e7-0a5a0ff4e31b]
      Fix: add Aqua and JET compat bounds to the main Project.toml [compat] section.

These are @test_broken in the grouped-tests QA group so CI is green; they will auto-flag (unexpected pass) once fixed. The remaining Aqua sub-checks (ambiguities, unbound args, undefined exports, project_extras, stale_deps, julia/deps/weakdeps compat, persistent_tasks) and JET.test_package all pass. Ignore until reviewed by @ChrisRackauckas.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the @test_broken checks in test/qa/qa.jl, then inspect the tuples methods at src/SciMLIterators.jl:137-138 and the [compat] section of Project.toml. The work is done when both piracy findings have an accepted resolution, Aqua and JET compatibility bounds are present, the checks are un-broken, and the QA group passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.