SciML / SciML/RuntimeGeneratedFunctions.jl
QA: Aqua/JET findings marked @test_broken pending fix
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 112
- Forks
- 19
- Avg merge
- 6h 11m
- Merged PRs (30d)
- 9
Description
While finalizing the grouped-tests CI conversion (branch grouped-tests-ci), the QA group's Aqua checks surfaced one genuine failure that is now wrapped as @test_broken in test/qa/qa.jl so the QA group is green and the PR can merge. It should be fixed and un-broken.
Finding (1 failure):
Aqua.test_deps_compat(RuntimeGeneratedFunctions)fails itsextrassub-check: the package does not declare a[compat]entry for the test-only extraPkg(44cfe95a-1eb2-52ea-b672-e2afdf69b78f).RuntimeGeneratedFunctions does not declare a compat entry for the following extras: Pkg [44cfe95a-1eb2-52ea-b672-e2afdf69b78f]
What was changed in the QA driver: Aqua.test_deps_compat is now called with check_extras = false (so the still-passing julia / deps / weakdeps sub-checks keep running and keep failing the suite if they regress), and the extras failure is recorded as @test_broken false referencing this issue.
Fix: add a [compat] entry for Pkg (e.g. Pkg = "1") in Project.toml, then remove the check_extras = false override and the @test_broken line.
Ignore until reviewed by @ChrisRackauckas.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review Project.toml and test/qa/qa.jl, then run the Aqua QA checks to reproduce the extras failure for Pkg. Add the stated Pkg compatibility entry, remove the check_extras override and @test_broken line, and rerun the QA suite so the extras check passes without suppressing it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 76/100