SciML / SciML/RecursiveArrayTools.jl
Eliminate ArrayInterfaceStaticArrays Dependency
Open
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 233
- Forks
- 76
- Avg merge
- 2h 17m
- Merged PRs (30d)
- 9
Description
See https://github.com/SciML/RecursiveArrayTools.jl/pull/205 for details, which has the MWE that was found.
There are two ways to do this. Either:
@generated function ArrayInterfaceCore.ismutable(::Type{<:ArrayPartition{T,S}}) where {T,S}
res = all(ArrayInterfaceCore.ismutable, S.parameters)
return :( $res )
end
that needs to be implemented differently so it respects back edges when StaticArrays' dispatches are added to ismutable, or ismutable needs to go to Base.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the MWE in pull request 205, then inspect the ArrayPartition ismutable implementation and the ArrayInterfaceCore and StaticArrays dispatches mentioned here. Done means ArrayInterfaceStaticArrays is no longer required and the MWE works without breaking the relevant ismutable behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- machine-learning
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100