SciML / SciML/OrgMaintenanceScripts.jl
QA: Aqua/JET findings marked @test_broken pending fix
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 4
- Forks
- 2
- Avg merge
- 32m
- Merged PRs (30d)
- 5
Description
The grouped-tests CI QA group (GROUP=QA -> test/qa.jl) runs Aqua.test_all and JET static analysis. Two Aqua sub-checks currently fail and have been marked @test_broken (not skipped/deleted) so the QA group is green and the grouped-tests-ci PR can merge. They should be fixed and un-broken:
-
Aqua stale dependencies —
isempty(stale_deps)failed. Stale deps:SnoopCompileCore,YAML(declared in[deps]but not actually loaded by the package). Fix by removing them from[deps](or moving to test/weakdeps) or actually using them. -
Aqua deps compat (
deps_compat) —OrgMaintenanceScriptsdoes not declare a[compat]entry for 7 deps:Dates,Distributed,LibGit2,Logging,Pkg,Printf,Random. Fix by adding compat bounds for these (stdlibs typically pinned to the supported Julia/stdlib versions).
All other Aqua sub-checks (method ambiguity, unbound type params, undefined exports, project_extras, extras/weakdeps compat, piracy, persistent tasks) pass, and JET static analysis is run. Only the two failing sub-checks above are @test_broken, each annotated with this issue link in test/qa.jl.
Ignore until reviewed by @ChrisRackauckas.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in test/qa.jl and run the grouped-tests QA group with GROUP=QA. Inspect the package dependency metadata for the stale-dependency and missing-compat findings, then remove the two @test_broken markers. Done means Aqua and the existing JET analysis pass with the QA group green.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- build-system, ci-cd, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100