SciML / SciML/ODEInterfaceDiffEq.jl

QA: Aqua/JET findings marked @test_broken pending fix

Open
#105 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
8
Forks
20
Avg merge
4h 53m
Merged PRs (30d)
9

Description

The grouped-tests QA group (test/qa/qa.jl) surfaces the following genuine Aqua/JET findings. They are currently marked @test_broken so the QA group is green and the grouped-tests CI can merge; they should be fixed and then un-broken (removing the @test_broken lines and re-enabling the corresponding checks).

Aqua
  • deps compat: ODEInterfaceDiffEq does not declare a [compat] entry for the LinearAlgebra stdlib dependency. Aqua's deps_compat check fails on it. Currently run as Aqua.test_all(ODEInterfaceDiffEq; deps_compat = false) plus a @test_broken false. Fix: add LinearAlgebra = "1" (or appropriate) to [compat], then re-enable deps_compat.
JET
  • JET.test_package: 1 possible error — ODEInterfaceDiffEq.uBottomEltype is not defined (used in __solve at src/solve.jl:37). The JET.test_package call is replaced with a @test_broken false. Fix: define/import uBottomEltype (it appears to be expected from DiffEqBase/RecursiveArrayTools), then restore JET.test_package.

All other Aqua sub-checks (method ambiguity, unbound type parameters, undefined exports, project/extras comparison, stale deps, piracy, persistent tasks) PASS and remain enabled.

Ignore until reviewed by @ChrisRackauckas.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in test/qa/qa.jl by reviewing the broken Aqua and JET checks. Trace ODEInterfaceDiffEq.uBottomEltype from src/solve.jl:37 and inspect the package dependency compatibility configuration. Done means the LinearAlgebra compatibility entry is present, uBottomEltype is resolved, the @test_broken lines are removed, and the corresponding checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.