SciML / SciML/ODEInterfaceDiffEq.jl
QA: Aqua/JET findings marked @test_broken pending fix
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 8
- Forks
- 20
- Avg merge
- 4h 53m
- Merged PRs (30d)
- 9
Description
The grouped-tests QA group (test/qa/qa.jl) surfaces the following genuine Aqua/JET findings. They are currently marked @test_broken so the QA group is green and the grouped-tests CI can merge; they should be fixed and then un-broken (removing the @test_broken lines and re-enabling the corresponding checks).
Aqua
- deps compat:
ODEInterfaceDiffEqdoes not declare a[compat]entry for theLinearAlgebrastdlib dependency. Aqua'sdeps_compatcheck fails on it. Currently run asAqua.test_all(ODEInterfaceDiffEq; deps_compat = false)plus a@test_broken false. Fix: addLinearAlgebra = "1"(or appropriate) to[compat], then re-enabledeps_compat.
JET
JET.test_package: 1 possible error —ODEInterfaceDiffEq.uBottomEltypeis not defined (used in__solveatsrc/solve.jl:37). TheJET.test_packagecall is replaced with a@test_broken false. Fix: define/importuBottomEltype(it appears to be expected fromDiffEqBase/RecursiveArrayTools), then restoreJET.test_package.
All other Aqua sub-checks (method ambiguity, unbound type parameters, undefined exports, project/extras comparison, stale deps, piracy, persistent tasks) PASS and remain enabled.
Ignore until reviewed by @ChrisRackauckas.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in test/qa/qa.jl by reviewing the broken Aqua and JET checks. Trace ODEInterfaceDiffEq.uBottomEltype from src/solve.jl:37 and inspect the package dependency compatibility configuration. Done means the LinearAlgebra compatibility entry is present, uBottomEltype is resolved, the @test_broken lines are removed, and the corresponding checks pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100