SciML / SciML/ModelingToolkitStandardLibrary.jl

Thermal sensors need outputs

Open
#384 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
171
Forks
49
Avg merge
15h 50m
Merged PRs (30d)
10

Description

Is your feature request related to a problem? Please describe.

The sensor components in the MTK Thermal library do not have output connectors. Thus they cannot be wired to other components as expected (i.e. PID, etc.). This request applies to TemperatureSensor, RelativeTemperatureSensor, and HeatFlowSensor.

Describe the solution you’d like

The sensed variables should be added to a RealOutput component.

Describe alternatives you’ve considered

A clear and concise description of any alternative solutions or features you’ve considered.

Additional context

For reference, you can look at Modelica Standard Library (i.e. Modelica.Thermal.HeatTransfer.Sensors.TemperatureSensor)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the MTK Thermal library implementations of TemperatureSensor, RelativeTemperatureSensor, and HeatFlowSensor, then compare their interfaces with Modelica.Thermal.HeatTransfer.Sensors.TemperatureSensor. Check how RealOutput is used elsewhere in the library and verify that each sensor exposes its sensed variable for wiring to components such as PID.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.