SciML / SciML/ModelingToolkitStandardLibrary.jl

FlowDivider missing equation?

Open
#326 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

question
Dominant language
Julia
Stars
171
Forks
49
Avg merge
15h 50m
Merged PRs (30d)
10

Description

Question❓

Hydraulic components - FlowDivider.
I see a commented line in equations which should define a dm on port_b. Is it missing something or does it work just fine? What was the idea?
Thank you.

    eqs = [connect(port_a, port_b, open.port)
           dm_a ~ port_a.dm
           dm_b ~ dm_a / n
           open.dm ~ dm_a - dm_b # extra flow dumps into an open port
           # port_b.dm ~ dm_b # divided flow goes to port_b
           ]

@bradcarman

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the FlowDivider implementation and inspect the equations block containing the commented port_b.dm line. Check how connect(port_a, port_b, open.port) determines the port flow variables and whether the component has coverage elsewhere. Done means establishing whether the equation is intentionally inferred or missing, then recording the confirmed behavior or a concrete correction.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.