SciML / SciML/ModelingToolkitStandardLibrary.jl
`PulseDiff` incorrect default
Open
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 171
- Forks
- 49
- Avg merge
- 15h 50m
- Merged PRs (30d)
- 10
Description
Electrical.PulseDiff returns ODESystem(eqs, t, [val], [], systems=[d], defaults=Dict(Val=>0), name=name).
However, Val is the keyword passed into the method, and val is the variable. Shouldn't this be Dict(val=>0)?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Electrical.PulseDiff definition shown in the issue and inspect how the keyword Val and variable val are used when constructing the ODESystem defaults. Confirm that the default is associated with the variable name, then verify the component's existing behavior or tests if available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100