SciML / SciML/LabelledArrays.jl

QA: Aqua/JET findings marked @test_broken pending fix

Open
#205 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
125
Forks
20
Avg merge
6h 3m
Merged PRs (30d)
10

Description

The grouped-tests QA group surfaced the following genuine Aqua/JET findings. They are currently wrapped as @test_broken in test/qa/qa.jl so the QA group runs green in CI; they should be fixed and un-broken.

Aqua (Aqua.test_all)Aqua.test_all(...; ambiguities=false, unbound_args=false, undefined_exports=false, deps_compat=false) is used so the remaining Aqua sub-checks (project_extras, stale_deps, piracies, persistent_tasks) still run; the following are @test_broken:

  • ambiguities: method ambiguities found.
  • unbound_args: unbound type parameters found.
  • undefined_exports: undefined exports found.
  • deps_compat: missing [compat] entries (deps + extras).

JET (JET.test_package)

  • 1 possible error found: setfield!: immutable struct of type LabelledArrays.LArray cannot be changed: setfield!(x::LArray, :__x, y::Any) in setproperty!(x::LArray, s::Symbol, y::Any) (src/larray.jl:96). The JET.test_package assertion is @test_broken.

All passing Aqua sub-checks remain enforced. These checks should be fixed and the @test_broken markers removed.

Ignore until reviewed by @ChrisRackauckas.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in test/qa/qa.jl, where the Aqua.test_all and JET.test_package checks are marked @test_broken. Inspect the reported immutable-field failure at src/larray.jl:96 and review each listed Aqua finding. Done means the findings are fixed, the @test_broken markers are removed, and the grouped QA checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.