SciML / SciML/JumpProcesses.jl
mutating parameter vector needs to call reset_aggregated_jumps!
Open
Nobody has claimed this yet.
bug
- Dominant language
- Julia
- Stars
- 150
- Forks
- 41
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 28
Description
Right now we only call reset_aggregated_jumps! when parameters are modified via remake or jprob[:psymb]. I don't think mutating jprob.prob.p directly will correctly lead to MassActionJumps getting updated.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the existing reset_aggregated_jumps! calls for remake and jprob[:psymb], then inspect how direct mutation of jprob.prob.p is handled. Done means direct parameter mutation reliably causes MassActionJumps to update; the payload names no files or tests to run.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100