SciML / SciML/DiffEqCallbacks.jl
SavingCallback used together with event handling callbacks
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 100
- Forks
- 54
- Avg merge
- 3h 29m
- Merged PRs (30d)
- 8
Description
Event handling callbacks (DiscreteCallback, ContinuousCallback) allow us to save u before and after the affect! with save_positions=(true,true). It would be a nice option for SavingCallback to save values before and after the affect! of event handling callback when those callbacks are used together in a CallbackSet.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the implementations and tests for SavingCallback, DiscreteCallback, ContinuousCallback, and CallbackSet. Check how save_positions currently records values around affect! and determine the expected before-and-after behavior when callbacks are combined. Done means the combined callbacks save both positions consistently, with tests covering the interaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100