SciML / SciML/ComponentArrays.jl

Fix type stability issues for getindex with symbols

Open
#9 1 comment 0 reactions 1 assignee View on GitHub

@jonniedie is already working on this.

Since Apr 30, 2020.

bug help wanted
Dominant language
Julia
Stars
375
Forks
42
Avg merge
7h 25m
Merged PRs (30d)
17

Description

Constant propagation works for Axis indexing but not for ComponentArray indexing. Not sure what to do here. I’m wrapping the symbolic indexes immediately in a Val and passing them into a function that calls a @generated function. fastindices is a workaround that I’d rather not have to have.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.