SciML / SciML/ComponentArrays.jl

`convert(T, y)` is not always a `T`

Open
#266 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
375
Forks
42
Avg merge
7h 25m
Merged PRs (30d)
17

Description

Is this expected?

julia> using ComponentArrays

julia> x = ComponentVector(a = [1, 2])
ComponentVector{Int64}(a = [1, 2])

julia> M = hcat(x, x)
2×2 ComponentMatrix{Int64} with axes Axis(a = 1:2,) × FlatAxis()
 1  1
 2  2

julia> y = convert(typeof(x), view(M, :, 1))
ComponentVector{Int64,SubArray...}(a = [1, 2])

julia> y isa typeof(x)
false

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the Julia reproduction using ComponentVector, ComponentMatrix, and view(M, :, 1), then inspect the conversion behavior involved. Done means establishing whether convert(typeof(x), view(M, :, 1)) is expected to preserve the exact type and identifying the relevant regression coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.