SciML / SciML/ComponentArrays.jl
assure type in getdata
Open
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 375
- Forks
- 42
- Avg merge
- 7h 25m
- Merged PRs (30d)
- 17
Description
Has assuring type information to getdata any drawbacks?
The following ::A avoids type instability at some of my code using ComponentVectors:
@inline CA.getdata(x::ComponentArray{T,N,A}) where {T,N,A} = getfield(x, :data)::A
@inline CA.getdata(x::ComponentVector{T,A}) where {T,A} = getfield(x, :data)::A
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the CA.getdata methods for ComponentArray and ComponentVector, then compare their type stability with and without the ::A assertions. Check whether the proposed signatures introduce drawbacks; done means the impact is established and the intended change or decision is clearly recorded.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100