SciML / SciML/ComponentArrays.jl
Check bounds on construction
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Julia
- Stars
- 375
- Forks
- 42
- Avg merge
- 7h 25m
- Merged PRs (30d)
- 17
Description
Everything we need to know about the named indices of theAbstractAxis types is available at construction. There is no reason we can’t just check bounds on construction and run all of the getindex/getproperty calls inbounds.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the AbstractAxis types and inspect how construction currently handles named indices, then trace the getindex and getproperty calls that use them. Determine the existing bounds behavior before changing it. Done means bounds are checked during construction and the relevant calls can run inbounds without changing their behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- performance
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100