SciCatProject / SciCatProject/backend

Attachment upload with nonexistent relationship is allowed

Open
#2,797 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
27
Forks
37
Avg merge
17h 32m
Merged PRs (30d)
38

Description

Summary

It is possible to create attachments which link to a nonexistent dataset/sample/proposal/published_data.

Steps to Reproduce

Create an attachment:

POST api/v4/attachments
{'caption': 'An attachment', 'ownerGroup': 'group1', 'relationships': [{'targetId': 'nonexistent-id', 'targetType': 'dataset', 'relationType': 'is attached to'}], 'accessGroups': ['group1'], 'isPublished': False, 'thumbnail': 'data:image/png;base64,OTI3OGM3OGE5MDRqaA=='}

This returns 200 with created attachment including an aid. Then

GET api/v4/attachments/{aid}

This now returns the attachment created above.

This also works when 'relationships' is empty.

Current Behaviour

The API allows creating 'dangling' attachments that are not attached to anything.

Expected Behaviour

The API should return an error if there are no relationships or the relationships point to an object that does not exist.
This would help avoid mistakes from pasting a bad ID into a relationship.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the POST api/v4/attachments endpoint and reproduce the requests in the issue, including an empty relationships array and a nonexistent targetId. Trace the attachment relationship validation and add or update coverage so invalid or missing relationships return an error; done means dangling attachments cannot be created while valid relationships still work.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.