Create PublishedData with public Datasets

Open
#2,378 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript
Domain
api, authorization, backend

Research direction

Start at src/published-data/published-data.v4.controller.ts around lines 421-429 and reproduce the UI flow with a public dataset. Trace the permission failure and determine whether the UI should reject datasets without update access or the backend should avoid updating an already-public dataset. Done means the flow no longer returns 403, or invalid selections are prevented before publishing.

Written by the indexing model from the issue text.

Description

Discussion needed

Summary

The UI lets you select Datasets you don't own (Public Data) when creating a PublishedData but trying to publish it will actually fail because it tries to set isPublished to true but the user doesn't have permissions for updating this kind of dataset

Steps to Reproduce

Select a public dataset when creating a PublishedData, fill in all required metadata, and try to publish it from the UI.

Current Behaviour

Fails with 403

Expected Behaviour

Option 1: disallow selection of datasets for which you don't have write access (update) in the UI

Option 2: don't fail/update if the dataset is already public

relevant code:
https://github.com/SciCatProject/scicat-backend-next/blob/583924143bb309ee586c220bf66718a8b413318b/src/published-data/published-data.v4.controller.ts#L421-L429

Details

Dominant language
TypeScript
Stars
27
Forks
37
Avg merge
17h 32m
Merged PRs (30d)
38

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from SciCatProject/backend

All issues in SciCatProject/backend

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.