SchemaStore / SchemaStore/schemastore

fulibworkflows false file match for *.es.yml / *.es.yaml translation files

Open
#3,334 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

fileMatch Conflict
Dominant language
JavaScript
Stars
3.8k
Forks
2.3k
Avg merge
20h 23m
Merged PRs (30d)
124

Description

Area with issue?

JSON Schema

✔️ Expected Behavior

Spanish language translation files name by [filename].es.yaml should not be matched to unrelated fulibworkflows json schema

❌ Actual Behavior

Any Spanish language yaml translation file, for example in symfony PHP framework, is incorrectly matched due to this merged PR.
https://github.com/SchemaStore/schemastore/pull/1826

It is a direct conflict with the exact pattern intended to match, so I don't know really what the solution is there.
Perhaps restrict it to when not located inside a "translations" parent folder? Bit ugly :S
More sensible would probably be working with fulibworkflows to make the matching filenames more specific?

YAML or JSON file that does not work.

spanish translation yaml

anything:
any_key_at_all: any value

IDE or code editor.

IntelliJ and it's derivatives

Are you making a PR for this?

No, someone else must create the PR.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the fulibworkflows schema change in the linked pull request and reproduce the match with the example Spanish translation YAML. Determine a matching rule that prevents *.es.yml and *.es.yaml files from being identified as that schema while preserving valid fulibworkflows matches.

Written by the indexing model from the issue text.

Assessment

Tech stack
json, yaml
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.