SagerNet / SagerNet/sing-box

deb package does not execute daemon-reload itself

Open Beginner friendly
#4,535 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Go
Stars
38.1k
Forks
4.6k
Avg merge
19d 15h
Merged PRs (30d)
1

Description

Operating system

Linux

System version

Debian 12 Bookworm

Installation type

Others

If you are using a graphical client, please provide the version of the client.

No response

Version
$ sing-box version
sing-box version 1.14.1

Environment: go1.26.8 linux/amd64
Tags: with_gvisor,with_quic,with_dhcp,with_wireguard,with_utls,with_acme,with_clash_api,with_tailscale,with_ccm,with_ocm,with_cloudflared,with_naive_outbound,with_usbip,with_openvpn,with_openconnect,badlinkname,tfogo_checklinkname0,with_musl
Revision: 1ac1a339cb1223e9c70eae14c44411c75033c02d
CGO: enabled
Description

Deb files in releases like these:
https://github.com/SagerNet/sing-box/releases/download/v1.14.1/sing-box_1.14.1_linux_amd64.deb

They do not execute systemd daemon-reload after package upgrade, so upgrading from 1.14.0 to 1.14.1 showed me an unnecessary

Warning: The unit file, source configuration file or drop-ins of sing-box.service changed on disk. Run 'systemctl daemon-reload' to reload units.

That is because timestamp of that file has get changed, although file contents are the same.

I think adding this

if [ -d /run/systemd/system ]; then
    systemctl --system daemon-reload >/dev/null || true
fi

to release/config/sing-box.postinst would fix the issue.

It's outside of scope of this issue, but maybe service should get restarted as well after these, it's opinion based really based on different projects.

Reproduction

Install not latest deb package, upgrade to a newer version.

Execute systemctl status sing-box.service.

Logs
Unnecessary

Warning: The unit file, source configuration file or drop-ins of sing-box.service changed on disk. Run 'systemctl daemon-reload' to reload units.
Supporter
Integrity requirements
  • I confirm that I have read the documentation, understand the meaning of all the configuration items I wrote, and did not pile up seemingly useful options or default values.
  • I confirm that I have provided the server and client configuration files and process that can be reproduced locally, instead of a complicated client configuration file that has been stripped of sensitive data.
  • I confirm that I have provided the simplest configuration that can be used to reproduce the error I reported, instead of depending on remote servers, TUN, graphical interface clients, or other closed-source software.
  • I confirm that I have provided the complete configuration files and logs, rather than just providing parts I think are useful out of confidence in my own intelligence.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with release/config/sing-box.postinst and review how the Debian package handles upgrades. Reproduce an upgrade from an older release, then check systemctl status sing-box.service; done means the package upgrade reloads systemd units and the unnecessary warning no longer appears.

Written by the indexing model from the issue text.

Assessment

Tech stack
linux, shell
Domain
devops, release
Issue type
Bug
Difficulty
1/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
86/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.