SagerNet / SagerNet/sing-box

adapter.InterfaceUpdateListener 部分方法函数签名不一致

Open
#1,911 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Go
Stars
38.2k
Forks
4.6k
Avg merge
19d 15h
Merged PRs (30d)
1

Description

Operating system

Others

System version

any

Installation type

Original sing-box Command Line

If you are using a graphical client, please provide the version of the client.

No response

Version
commit 8d2cb5c
Description

adapter.InterfaceUpdateListener 接口方法为:

type InterfaceUpdateListener interface {
	InterfaceUpdated()
}

但在 Hysteria / Hysteria2 Outbound 中方法签名为:

func (h *Hysteria) InterfaceUpdated() error {
	return h.client.CloseWithError(E.New("network changed"))
}

func (h *Hysteria2) InterfaceUpdated() error {
	return h.client.CloseWithError(E.New("network changed"))
}
Reproduction

在 commit 8d2cb5c 中仍然存在

Logs

No response

Supporter
Integrity requirements
  • I confirm that I have read the documentation, understand the meaning of all the configuration items I wrote, and did not pile up seemingly useful options or default values.
  • I confirm that I have provided the server and client configuration files and process that can be reproduced locally, instead of a complicated client configuration file that has been stripped of sensitive data.
  • I confirm that I have provided the simplest configuration that can be used to reproduce the error I reported, instead of depending on remote servers, TUN, graphical interface clients, or other closed-source software.
  • I confirm that I have provided the complete configuration files and logs, rather than just providing parts I think are useful out of confidence in my own intelligence.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the adapter.InterfaceUpdateListener definition and locating the Hysteria and Hysteria2 outbound implementations of InterfaceUpdated. Determine the intended matching signature, then verify that the interface and both implementations are consistent and the project checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.