SSWConsulting / SSWConsulting/TimePro.Tools
`tp leave list --json` does not surface the top-level `cancelledCount` AGENTS.md says it does
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 3
- Forks
- 0
- Avg merge
- 29m
- Merged PRs (30d)
- 28
Description
Found while implementing #52. ListCommand and the MCP GetLeaveEntries tool serialise only the items array, so the list envelope's cancelledCount (and totalItems) never reach the caller, although AGENTS.md states they surface in tp leave list --json.
Expected: either wrap the JSON output in an envelope ({"items": [...], "totalItems": N, "cancelledCount": N}) as a deliberate, announced shape change (0.4.0 candidate, since scripts parse the bare array today), or correct AGENTS.md. Recommend the envelope in 0.4.0 alongside the other contract changes, with MCP mirroring it through LeaveListService.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with ListCommand and the MCP GetLeaveEntries tool, then read AGENTS.md and inspect how LeaveListService represents the list envelope. Resolve whether the JSON contract should become an envelope or the documentation should change, including the effect on existing scripts. Done means the CLI and MCP behavior and AGENTS.md agree on totalItems and cancelledCount.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- api, cli, documentation
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100