SSWConsulting / SSWConsulting/SSW.Website

🐛 Bug - Video section caption renders as heading due to incorrect markup

Open
#4,655 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Needs Refinement YakShaver
Dominant language
HTML
Stars
14
Forks
10
Avg merge
13h 51m
Merged PRs (30d)
38

Description

Requested by: @tiagov8 via YakShaver.ai 🦬
cc: @tiagov8, @brookjeynes-ssw, @babakamyljanovssw @hveraus @PennyWalker @adamcogan

Email thread where I discovered this: Re: SSW Newcastle Directions - video

Hi Team!

  🟥  Watch the video (1 min 12 sec)

  Url from screen share: https://ssw.com.au/offices/newcastle

Pain

On the Newcastle office page, the video section caption is rendered with the same size and bold styling as the heading, making it more prominent than the actual heading. Investigation shows the heading tag is not correctly closed and is wrapping the entire section. This results in incorrect semantics, styling, and accessibility. The markup for this component should be fixed so the heading ends at the correct point. As this appears to be a shared component, other pages using it should also be checked for the same issue.

Acceptance Criteria
  1. The video section heading on the Newcastle office page is correctly closed in the markup.
  2. The caption text is no longer rendered with heading-level size or bold styling.
  3. Heading and caption styles match the design system and expected hierarchy.
  4. HTML markup is semantically correct and accessible.
  5. All pages using the same component are reviewed and confirmed to be free of the same issue.
Reproduce Steps
  1. Navigate to www.ssw.com.au.
  2. Open the Newcastle office page.
  3. Scroll to the video section.
  4. Observe that the caption text appears the same size and weight as the heading.
  5. Inspect the HTML and note that the heading tag wraps the entire section instead of ending after the heading text.
Screenshot

Screenshot
Figure: Video section heading markup incorrectly wraps entire section, causing caption to appear as a heading

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Newcastle office page and inspect the video section's rendered HTML, then trace the shared component used there across other pages. Verify the heading boundary, caption styling, semantic hierarchy, and accessibility in the browser; done means the Newcastle page and every page using that component render without the incorrect heading wrapper.

Written by the indexing model from the issue text.

Assessment

Tech stack
html, nextjs
Domain
accessibility, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.