SSWConsulting / SSWConsulting/SSW.Rules
🐛 / ♻️ Most archived rules won't show on /Archived page since they are uncategorized
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 26
- Forks
- 17
- Avg merge
- 14h 39m
- Merged PRs (30d)
- 2
Description
Cc: @adamcogan @BrookJeynes
Hi @bradystroud
Describe the Bug
I just noticed that the /Archived page is divided by category
This means it only shows the archived rules that are still on a category list...
However... since forever I've been removing the archived rules from the categories (e.g. https://github.com/SSWConsulting/SSW.Rules.Content/pull/4896)
The reason is to keep the category pages clean and easy to organize, order, etc
All these uncategorized archived rules are not being shown in the /Archived page
Expected Behavior
ALL archived rules should be on https://ssw.com.au/rules/archived/
I see 2 approaches:
A. Make the /Archived page a big long list with ALL rules (no categories/sections)
B. Find ALL the uncategorized archived rules and add them back to a category
I tend to prefer A since it's easier to implement.
From my perspective these rules are NOT relevant, so there is no reason to put effort in making them organized by categories.
Tasks
- Consider my options, see if there is another way, and action
- Update the Wiki https://github.com/SSWConsulting/SSW.Rules.Content/wiki/How-to-Archive-Rules to include what was decided
Thanks!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the /rules/archived/ page and trace how archived rules are grouped, checking whether uncategorized rules are excluded. Compare the available approaches against the expected behavior, then verify that every archived rule appears and update the How-to-Archive-Rules wiki page with the decision.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- nextjs, typescript
- Domain
- documentation, frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100