SSWConsulting / SSWConsulting/SSW.Rules

🐛 GIF images won't get an alt attribute

Open
#873 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Type: Bug
Dominant language
TypeScript
Stars
26
Forks
17
Avg merge
14h 39m
Merged PRs (30d)
2

Description

Cc: @tombui99 @adamcogan

Hi @bradystroud

Describe the Bug

I noticed that some of the errors on CodeAuditor for this rule Images - missing alt attribute are because the images are with .gif extension

E.g. https://www.ssw.com.au/rules/how-to-take-feedback-or-criticism
This rule has a gif and a png in its content and only the first one doesn't have an alt attribute.

Expected Behavior

All images under rules should have an alt attribute so they don't show in CodeAuditor's reports

Tasks
  • Investigate
  • Fix
Screenshots

GIF code compared to PNG code:

Screen Shot 2022-06-13 at 3 36 34 PM Screen Shot 2022-06-13 at 3 38 15 PM

Thanks!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked Images - missing alt attribute rule and the cited SSW Rules page, comparing how the GIF and PNG images are handled. Investigate the CodeAuditor report for the GIF case; done means GIF images under rules receive alt attributes and no longer appear in that report.

Written by the indexing model from the issue text.

Assessment

Tech stack
html
Domain
accessibility
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.