SSWConsulting / SSWConsulting/SSW.Rules
UI - Consolidate "Remove Tag" Icons on Profile Page
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 26
- Forks
- 17
- Avg merge
- 14h 39m
- Merged PRs (30d)
- 2
Description
As per my conversation with @bradystroud,
cc: @tiagov8
The rating icons listed on each rule in the user profile page have no function currently. These were originally intended to allow users to unbookmark rules / unlike rules / etc but X icons have been added to serve this purpose. The red bar under the "bookmarks" tab makes it clear that this is a list of bookmarked rules, so these icons are not needed for that purpose either.
- Remove the rating icons from the listed rules on the profile page OR replace the X icons with these icons.
NOTE: The figures below also show changes suggested in #509 and #505

Figure: Option A - x icons to remove a rule from bookmarks

Figure: Option B - relevant icons grey out on hover and remove rule from profile on click
I would prefer option B as this feels the most intuitive - I believe removing bookmarks/likes in this way is standard and expected behaviour for this kind of interface.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the profile page implementation and inspect how the rating icons and X icons are rendered for listed rules. Confirm whether option A or B is intended, then remove or consolidate the redundant controls and verify that bookmark and like actions still work as expected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- nextjs, typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100