SSWConsulting / SSWConsulting/SSW.Rules

🦙🚨 Bug - TinaCMS Dependency - Images uploaded via TinaCMS editor are not synced to source control

Open
#2,400 14 comments 5 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

TinaCMS YakShaver
Dominant language
TypeScript
Stars
26
Forks
17
Avg merge
14h 39m
Merged PRs (30d)
2

Description

Requested by: @KostaMadorsky via YakShaver.ai 🦬
cc: @KostaMadorsky, @KahaMason, @Marxoz, @PothieuG, @Freego1783, @jakebayliss, @JackDevAU, @brookjeynes-ssw , @wicksipedia

Hi Team!

  🟥  Watch the video (6 min 35 sec)

  Url from screen share: https://github.com/SSWConsulting/SSW.Rules.Content/pull/1178?changes

Pain

When editing Rules V3 (TinaCMS) content using the TinaCMS editor, images uploaded via the Media Manager (drag & drop or upload) are stored only in TinaCloud and are not committed to the Git repository. Although the editor warns that a pull request is required, the image still appears selectable and can be inserted and saved. After refresh or deployment, the rule references an image that does not exist in source control, causing images to be missing locally and in non-production environments. Uploading images through a GitHub pull request works correctly, highlighting an inconsistency and risk of content/image loss when using the UI-only workflow.

Acceptance Criteria
  1. Images uploaded via the TinaCMS editor are committed to the connected Git repository as part of a pull request
  2. The editor prevents saving or inserting images that are not synced to source control
  3. Media Manager only shows images that exist in source control or clearly indicates their sync status
  4. After refresh, deployment, or environment switch, images referenced in rules continue to render correctly
  5. Behavior is consistent between UI-only edits and pull-request-based workflows
  6. No images remain stored only in TinaCloud without a corresponding Git commit
Reproduce Steps
  1. Start editing a rule via Rules V3 (TinaCMS) editor and Save so it creates a pull request
  2. Edit an image and open the Media Manager
  3. Drag and drop or upload a new image via the editor UI
  4. Dismiss the warning indicating a pull request is required
  5. Insert the uploaded image into the rule and click Save
  6. Refresh the page or check the GitHub repository
  7. Observe that the rule references the image but the image file does not exist in the pull request
Screenshot

Screenshot
Figure: Image uploaded via editor exists only in TinaCloud and is missing from source control after refresh

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in the Rules V3 TinaCMS editor through the Media Manager, then compare the UI workflow with the referenced pull request #1178. Trace how uploaded images are handled before the rule pull request is created. Done means uploaded images are synchronized with Git, unsynchronized images cannot be saved or are clearly marked, and references still render after refresh or deployment.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, nextjs, typescript
Domain
content, web-dev
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.