SSWConsulting / SSWConsulting/SSW.Rules.Content

External images not working with lightbox, and not suitable for long term reliability.

Open
#2,061 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
MDX
Stars
62
Forks
196
Avg merge
1d 4h
Merged PRs (30d)
112

Description

Cc: @adamcogan @tombui99 @pierssinclairssw @theixdev @zacharykeeping @tiagov8

Hi All,

It is of concern that external images (even SSW.com.au) are too volatile and it is better to store images within the git folder itself.

Additionally, the Gatsby module for creating lightboxes on image click does not function for images that are not in the git folder.

  • Create a rule to find images not stored in Git.
  • Fix images so that they are stored in Git.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the existing rule that finds images not stored in Git, then inspect the Gatsby lightbox behavior for external images. Done means the remaining external images are stored in the repository and lightbox behavior works for them; verify the existing image-checking rule afterward.

Written by the indexing model from the issue text.

Assessment

Tech stack
git
Domain
content, documentation
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.