SSWConsulting / SSWConsulting/SSW.Rewards.Mobile
♻️ Warnings as errors
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 37
- Forks
- 11
- PR merge metrics
- No merged PRs in 30d
Description
Cc: @tkapa @zacharykeeping
Hi
Pain
While merging in the code with git history from the Admin Portal and API (see #564) we had over 900 warnings. To not be blocked by this, we disabled treat warnings as errors.
What code could be improved?
Treat warnings as errors should be re-enabled, and all the warnings should be resolved.
Tasks
- Re-enable treat warnings as errors
- Resolve all the warnings
Acceptance Criteria
- Meets Definition of Done
Thanks!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files, tests, or entry points are named; begin by locating the warning-as-error configuration and inventorying the warnings introduced during the Admin Portal and API merge described in #564. Done means warning-as-error treatment is re-enabled and all resulting warnings are resolved, with the project's checks passing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- build-system, mobile-dev
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100