SSWConsulting / SSWConsulting/SSW.CleanArchitecture
🐛 Merging from forks is not working
A pull request for this has already been merged.
- #198 by @wicksipedia — merged
- Dominant language
- C#
- Stars
- 199
- Forks
- 37
- PR merge metrics
- No merged PRs in 30d
Description
Cc: @GordonBeeming @danielmackay @Hona @william-liebenberg @wicksipedia
Hi team,
Describe the Bug
When creating a PR from a fork will always result in the build failing.
Figure: Build will always fail on this step.
There is nothing the author of the PR can do to fix this issue. It's a security issue that prevents the build from ever passing.
To Reproduce
Steps to reproduce the behaviour:
- Create a fork
- Make any change (even a Markdown file)
- Create PR into this repository
- See the build fail
Expected Behavior
External people should be able to give mergeable PRs to SSW.CleanArchitecture for improvements and suggestions.
PS: Can avoid this in the future so that it is easier to contribute to SSW projects?
Tasks
- Investigate
- Update test or variables so that PRs from forks can work
Screenshots
Figure: Changed just a markdown that would not impact the build and yet it fails.
Figure: Only Markdown was changed.
Thanks!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the failing build step and the CI variables or tests involved in pull requests from forks; the issue does not name specific files. Reproduce the failure with a fork and a Markdown-only change, then compare the result with merged pull request #198. Done means an external fork can produce a passing, mergeable build.
Written by the indexing model from the issue text.
Assessment
- Domain
- ci-cd, security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100