SFTtech / SFTtech/openage

Crash on non-optimized build on windows

Open
#981 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug lang: c++ os: windows
Dominant language
Python
Stars
14.4k
Forks
1.3k
PR merge metrics
No merged PRs in 30d

Description

Hello,

since I haven't got the debug build on windows to run successfully, but wanted to fix some test I just tried disabling the Optimizations on libopenage for some smoother debugging experience.

I got a ACCESS_VIOLATION crash when I tried that on the function qmlRegisterTypes<>.
I probably ran into the same problem these guys have: https://github.com/benlau/quickflux/issues/7 and did the same thing to fix the problem as they did. I bundled all the global static calls and wrapped them around Q_COREAPP_STARTUP_FUNCTION so they are called after QCoreApplication has been initialized.

You can see my progress there:
https://github.com/schnema123/openage/commit/25bde24e278fbe6ee6588131f9a03fa7343c5afb

Could there be any problems on linux with this setup?

Greetings

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at qmlRegisterTypes<> and inspect the global static calls changed in commit 25bde24e278fbe6ee6588131f9a03fa7343c5afb. Reproduce the ACCESS_VIOLATION in a non-optimized Windows build, then check the same initialization setup on Linux. Done means the build runs without the crash and any platform-specific problems are documented or covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system, operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.