SFTtech / SFTtech/openage

Trigger reconfigure when git commit hash changes

Open
#381 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area: buildsystem good first issue improvement just do it
Dominant language
Python
Stars
14.4k
Forks
1.3k
PR merge metrics
No merged PRs in 30d

Description

When the value of git describe changes, we should trigger a reconfigure when typing make. This ensures the version generated to config.h matches with the actual repository version.

The "dirty" solution would be checking for the version each time, something better would be a update watch on some file in ./.git/, but maybe you have a better idea how cmake may detect a changed HEAD efficiently.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the CMake configuration invoked by make and the generation path for config.h; inspect how the value from git describe is currently obtained and what dependencies are declared. Test behavior after changing the repository commit hash, and consider the .git/ watch approach mentioned in the issue. Done means make reconfigures when the hash changes and config.h matches the repository version.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, git
Domain
build-system
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.