audio::DynamicResource chunk reusage incorrect

libopenage/audio/dynamic_resource.h
This class defines a hashmap and a queue to maintain the audio chunks.

datastructure::ConcurrentQueue<std::shared_ptr<chunk_info_t>> decay_queue;
std::unordered_map<size_t,std::shared_ptr<chunk_info_t>> chunks;

Both of them keep a pointer to the actual chunk. However, when a chunk is recycled from the queue, there is no way to invalidate the pointer in chunks. Thus the same chunk can still be found with an outdated index, but it may contain incorrect audio data.

I think the queue should keep indexes of the hashmap, not pointers to the chunks (which are values of the hashmap).

Start with libopenage/audio/dynamic_resource.h and inspect the DynamicResource class, especially decay_queue and chunks. Trace how chunks are added, recycled, and looked up to confirm when an outdated index can return incorrect audio data. Done means recycled chunks can no longer be found through stale hashmap entries while chunk reuse remains correct.