SFTtech / SFTtech/openage

Create Nyan.cmake for nyan related processing inside /buildsystem

Open
#1,240 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area: buildsystem lang: cmake to-discuss
Dominant language
Python
Stars
14.4k
Forks
1.3k
PR merge metrics
No merged PRs in 30d

Description

Currently the nyan integration is done here somehow. What about separating things from above to mentioned buildsystem/modules/FindNyan.cmake and call find_package(nyan REQUIRED CONFIG) from libopenage/CMakeLists.txt?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the nyan integration around line 69 of libopenage/CMakeLists.txt and compare it with the requested buildsystem/modules/FindNyan.cmake location. Separate the existing nyan-related processing there and add the requested find_package(nyan REQUIRED CONFIG) call. Done means the integration is handled through the buildsystem module and the project still configures successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake
Domain
build-system
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.