SFTtech / SFTtech/openage

Disable downloading for CI builds in cmake

Open
#1,122 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area: buildsystem ci os: windows packaging
Dominant language
Python
Stars
14.4k
Forks
1.3k
PR merge metrics
No merged PRs in 30d

Description

I tried to package offline and saw this todo "Disable downloading for CI builds". This is just another reminder for us. The buildscript will already patch EmbedPython.cmake and EmbedFont.cmake and make it unpack a pre-downloaded version though.

Changes should be made in:
openage/buildsystem/scripts/EmbedFont.cmake
openage/buildsystem/scripts/EmbedPython.cmake

It makes sense to stay with different options:

  • Kevin: pre-downloaded->Path in filesystem -> (CI-flag)
  • Script: patches newly downloaded repository on the fly
  • Normal Repo: As is

So I guess, we want something like a flag for kevin e.g., to decide to use an archive offline, right?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading openage/buildsystem/scripts/EmbedFont.cmake and openage/buildsystem/scripts/EmbedPython.cmake, then trace how the buildscript patches them for pre-downloaded archives. Determine how the normal repository, patched script, and CI/offline paths should differ; done means CI builds can use the pre-downloaded versions without attempting downloads.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake
Domain
build-system, ci-cd
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.