CORS update for ycommercewebservices for 2005
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 11
- Forks
- 22
- Avg merge
- 7d 3h
- Merged PRs (30d)
- 2
Description
The following applies to all Spartacus releases (1.0 and 2.0).
Everywhere that the following are mentioned:
corsfilter.ycommercewebservices.allowedHeaders
corsfilter.ycommercewebservices.exposedHeaders
If you are using 2005 or later, in the default recipe, the commercewebservices extension is used instead of ycommercewebservices (OCC extensions vs addons). So the CORS entry has to be withouth the 'y' prefix:
corsfilter.commercewebservices.allowedHeaders
corsfilter.commercewebservices.exposedHeaders
However, if you are using 2005 or later with the OCC addons (you've gone back to ycommercewebservices etc.), then the original header defintions are correct:
corsfilter.ycommercewebservices.allowedHeaders
corsfilter.ycommercewebservices.exposedHeaders
The use of "ycomm..." or just "comm" depends if you are using ycommercewebservices extensions (=OCC addons) or commercewebservices extensions (=OCC extensions).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the documentation for corsfilter.ycommercewebservices.allowedHeaders and corsfilter.ycommercewebservices.exposedHeaders. Check each occurrence against the 2005-and-later recipe and whether it uses commercewebservices extensions or OCC addons; done means the documented CORS keys match that choice everywhere.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- html
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100