fromisotime cleanup when 3.11 is Python miniumum
Open
Beginner friendly
Nobody has claimed this yet.
chore
- Dominant language
- Python
- Stars
- 268
- Forks
- 100
- PR merge metrics
- No merged PRs in 30d
Description
Matrix builds for #303 exposed change in fromisotime for fractional-seconds between Python 3.10 and 3.11. Since 3.10 EOL is quite soon, adding what can be changed when support for 3.10 will be dropped as well.
Cleanup tasks for when Python 3.11 becomes minimum version
-
parse_datetime_literalinpyodata/v2/model.py: remove fractional-seconds padding workaround (theif '.' in valueblock),fromisoformataccepts any number of fractional digits in 3.11+ -
EdmDateTimeOffsetTypTraits.from_literalinpyodata/v2/model.py: remove fractional-seconds padding workaround (theif '.' in normalizedblock) for the same reason -
EdmDateTimeOffsetTypTraits.from_literal: remove the.replace('Z', '+00:00')normalisation,fromisoformatacceptsZnatively in 3.11+
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open pyodata/v2/model.py and inspect parse_datetime_literal and EdmDateTimeOffsetTypTraits.from_literal. Confirm the Python 3.11 fromisoformat behavior, then remove the fractional-seconds padding blocks and the Z replacement described in the issue. Done means the compatibility workarounds are gone while fractional seconds and Z inputs remain supported.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 78/100