perform checks based on NavigationProperty multiplicity
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 268
- Forks
- 100
- PR merge metrics
- No merged PRs in 30d
Description
When creating a new entity, it is possible to call the method set with an invalid value for a navigation property because the method set does not verify multiplicity of the corresponding navigation property relation ship. To put it simple, it is possible to assign a list to a navigation property which is supposed to be an entity.
More explicitly, we need to add a check for multiplicity before the following line:
https://github.com/SAP/python-pyodata/blob/master/pyodata/v2/service.py#L489
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in pyodata/v2/service.py around line 489 and trace the set method for newly created entities. Check how the navigation property's multiplicity is available, then ensure values assigned through set match that multiplicity. Done means an entity-valued navigation property rejects a list while valid assignments continue to work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 58/100