ODataHttpRequest : headers inherited from the connection arg are not handled
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 268
- Forks
- 100
- PR merge metrics
- No merged PRs in 30d
Description
When executing a request with pyodata's Client, one may need to use some headers, for example for authentication purpose. ODataHttpRequest takes both a Connection argument and a headers keyword-argument, whereas Connection object might already have a headers attribute.
Hence, ODataHttpRequest's init() should merge headers from Connection and from args, overriding the first with the second if necessary.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at ODataHttpRequest.init and inspect how headers from the Connection argument and the headers keyword argument are handled. Confirm the intended precedence described in the issue, then verify that requests preserve inherited headers while allowing explicitly supplied headers to override them.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 62/100