SAP / SAP/pull-request-semver-bumper

Fix the failing upgrades

Open
#154 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
3
Forks
4
Avg merge
11d 11h
Merged PRs (30d)
3

Description

#135

build-test-core is failing — TypeScript 7 is not yet supported by our test toolchain

I looked into the failing build-test-core check. There are two layers to it:

1. Surface error (lockfile out of sync)
package.json was bumped to typescript@^7.0.0 but package-lock.json still pins typescript@6.0.3, so npm ci fails:

npm error `npm ci` can only install packages when your package.json and package-lock.json are in sync.
npm error Invalid: lock file's typescript@6.0.3 does not satisfy typescript@7.0.2

2. The real blocker (ts-jest does not support TS 7)
Regenerating the lockfile does not fix it. TypeScript 7.0 is the new native ("tsgo") compiler generation, and our test runner ts-jest is incompatible with it:

  • ts-jest@29.4.11 (latest) declares peer typescript: ">=4.3 <7", so npm ci then hard-fails with ERESOLVE.
  • Even bypassing the peer check, npm test crashes because ts-jest cannot consume the TS 7 compiler API:
    TypeError: Cannot read properties of undefined (reading 'readFile')
        at ConfigSet._resolveTsConfig (node_modules/ts-jest/.../config-set.js)
    
  • npm view ts-jest peerDependencies confirms no released ts-jest version (latest 29.4.11, next 29.0.0-next.1) allows typescript >=7.

Good news: the source itself is TS 7-ready — tsc (7.0.2) compiles it cleanly (exit 0). The only blocker is the Jest transformer.

Recommendation: hold this bump until ts-jest publishes TypeScript 7 support. Migrating off ts-jest (to swc/babel/vitest) purely to satisfy this Renovate bump would be unjustified test-infra risk (ESM handling, path resolution, @actions/core mocks, diagnostics). Once npm view ts-jest peerDependencies allows typescript >=7 and a local npm ci && npm test && npm run build passes without peer overrides, this can be taken as a normal dependency update.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with package.json and package-lock.json, then inspect the build-test-core check and run npm view ts-jest peerDependencies. This is done when a released ts-jest version supports TypeScript 7 and npm ci, npm test, and npm run build pass without peer overrides.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js, typescript
Domain
build-system, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.